From: | Wolfgang Walther <walther(at)technowledgy(dot)de> |
---|---|
To: | Tristan Partin <tristan(at)partin(dot)io>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Building with meson on NixOS/nixpkgs |
Date: | 2024-08-17 21:24:43 |
Message-ID: | a63ae81b-bb19-4dad-b787-7e5d6414ebfb@technowledgy.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tristan Partin:
> On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote:
> [..]
>> commit a00fae9d43e5adabc56e64a4df6d332062666501
>> Author: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
>> Date: 2024-07-27 13:53:08 +0300
>>
>> Fallback to uuid for ossp-uuid with meson
>> [..]
>>
>> I think this is a redundant change with
>>
>> commit 2416fdb3ee30bdd2810408f93f14d47bff840fea
>> Author: Andres Freund <andres(at)anarazel(dot)de>
>> Date: 2024-07-20 13:51:08 -0700
>>
>> meson: Add support for detecting ossp-uuid without pkg-config
>> [..]
>
> I'm not sure I would call them redundant. It's cheaper (and better) to
> do a pkg-config lookup than it is to do the various checks in your
> patch. I think the two patches are complementary. Yours services Windows
> plus anywhere else that doesn't have a pkg-config file, while Wolfgang's
> services distros that install the pkg-config with a different name.
Agreed.
There is also a small difference in output for meson: When uuid is
queried via pkg-config, meson also detects the version, so I get this
output:
External libraries
[..]
uuid : YES 1.6.2
Without pkg-config:
External libraries
[..]
uuid : YES
Best,
Wolfgang
From | Date | Subject | |
---|---|---|---|
Next Message | Wolfgang Walther | 2024-08-17 21:43:37 | Re: Building with meson on NixOS/nixpkgs |
Previous Message | Joe Conway | 2024-08-17 20:05:30 | Re: gitmaster server problem? |