Re: Take skip header out of a loop in COPY FROM

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Adam Lee <ali(at)pivotal(dot)io>
Cc: Surafel Temesgen <surafel3000(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Take skip header out of a loop in COPY FROM
Date: 2019-08-22 10:04:14
Message-ID: a5ebb17a-320b-5b21-c159-7e796456f134@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22/08/2019 12:54, Adam Lee wrote:
> My next thought is to call unlikely() here, but we don't have it...
> https://www.postgresql.org/message-id/CABRT9RC-AUuQL6txxsoOkLxjK1iTpyexpbizRF4Zxny1GXASGg%40mail.gmail.com

We do, actually, since commit aa3ca5e3dd in v10.

Not sure it's worth the trouble here. Optimizing COPY in general would
be good, even small speedups there are helpful because everyone uses
COPY, but without some evidence I don't believe particular branch is
even measurable.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-08-22 10:23:24 Re: POC: Cleaning up orphaned files using undo logs
Previous Message Adam Lee 2019-08-22 09:54:47 Re: Take skip header out of a loop in COPY FROM