From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: CALL stmt, ERROR: unrecognized node type: 113 bug |
Date: | 2018-02-13 20:26:20 |
Message-ID: | a5dafb46-9b87-c64f-fbd9-82b8b2a9e078@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2/13/18 03:57, Michael Paquier wrote:
> On Mon, Feb 12, 2018 at 03:19:27PM -0500, Tom Lane wrote:
>> I've not read in detail, but it looks reasonable offhand, modulo
>> that I still don't like prorettype == 0 ;-).
>>
>> I did notice a tiny typo:
>>
>> - * with. Hence prefer "$function$", but extend if needed.
>> + * with. Hence prefer "$function$"/"$procedure", but extend if needed.
>>
>> I think you want
>>
>> + * with. Hence prefer "$function$"/"$procedure$", but extend if needed.
done
> 0001 and 0002 are welcome. I have a small comment on top of Tom's for 0003.
>
> + appendStringInfoString(&buf, ")\n");
> + if (proc->prorettype)
> + {
> + appendStringInfoString(&buf, " RETURNS ");
> + print_function_rettype(&buf, proctup);
> + appendStringInfoChar(&buf, '\n');
> + }
> Could you use a separate boolean variable which is set as
> OidIsValid(prorettype), say called isfunction?
done
> Should the documentation of pg_function_is_visible also mention
> procedures?
done
and committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-02-13 20:27:50 | spelling of enable_partition_wise_join |
Previous Message | Robert Haas | 2018-02-13 19:21:51 | Re: [HACKERS] Client Connection redirection support for PostgreSQL |