Re: CREATE SUBSCRIPTION - add missing test case

On 10/01/2025 05:11, Peter Smith wrote:
> On Sun, Dec 8, 2024 at 10:57 AM Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>> Yes, there are cases with logical replication where reproducing may be
>> expensive (in terms of data amounts, time, ...) but I don't think that's
>> the case here - this test is trivial/cheap.
>>
>> But I believe the "costs" mentioned by Amit are more about having to
>> maintain the tests etc. rather than execution costs. In which case
>> having a flag does exactly nothing - we'd still have to maintain it.
>>
>> I propose we simply add the test to 008_diff_schema.pl, per v2. I see no
>> reason to invent something more here.
>
> Hi Tomas,
>
> Since you think patch v2 is already OK as-is, I have changed the
> commitfest entry [1] for this to RfC.

Committed, thanks!

It's always a balancing act between test coverage and how long the tests
run. I agree this test is worth it, albeit with a thin margin.

--
Heikki Linnakangas
Neon (https://neon.tech)