| From: | Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH pglister] Add Archived-At header to delivered messages |
| Date: | 2021-03-02 10:41:58 |
| Message-ID: | a5067487-ceb0-edc5-3367-702d5749a6d5@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
Hi,
Magnus Hagander a écrit :
> There are a few issues.
>
> * It needs a rebase because the migration doesn't work (needs to be
> based on the latest)
> * You cannot CREATE OR REPLACE a view if you add a field in the
> middle. The new field has to be added at the end.
> * It crashes on lists that don't have an archive. I think you just
> need an "if self.archive_mailurlpattern:" wrapping it
Thanks for the review. Please find attached a new version of the patch
fixing these issues hopefully.
Let me know if there's anything else,
Denis
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-Archived-At-header-to-delivered-messages.patch | text/x-patch | 6.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2021-03-03 10:15:05 | Re: [PATCH pglister] Add Archived-At header to delivered messages |
| Previous Message | Stephen Frost | 2021-03-01 17:20:34 | Re: [PATCH pglister] Add Archived-At header to delivered messages |