Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit

From: David Zhang <david(dot)zhang(at)highgo(dot)ca>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit
Date: 2022-04-19 19:54:49
Message-ID: a4c7fd7a-4bcd-a783-9055-2d85d8299217@highgo.ca
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I tried to apply the patch to master and plan to run some tests, but got
below errors due to other commits.

$ git apply --check
v7-0003-postgres-fdw-Add-support-for-parallel-abort.patch
error: patch failed: doc/src/sgml/postgres-fdw.sgml:479
error: doc/src/sgml/postgres-fdw.sgml: patch does not apply

+     * remote server in parallel at (sub)transaction end.

Here, I think the comment above could potentially apply to multiple
remote server(s).

Not sure if there is a way to avoid repeated comments? For example, the
same comment below appears in two places (line 231 and line 296).

+    /*
+     * If requested, consume whatever data is available from the socket.
+     * (Note that if all data is available, this allows
+     * pgfdw_get_cleanup_result to call PQgetResult without forcing the
+     * overhead of WaitLatchOrSocket, which would be large compared to the
+     * overhead of PQconsumeInput.)
+     */

On 2022-03-24 11:46 p.m., Etsuro Fujita wrote:
> On Thu, Mar 24, 2022 at 1:34 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>> Attached is a new patch set. The new version of 0002 is just a
>> cleanup patch (see the commit message in 0002), and I think it's
>> committable, so I'm planning to commit it, if no objections.
> Done.
>
> Attached is the 0003 patch, which is the same as the one I sent yesterday.
>
> Best regards,
> Etsuro Fujita
--
Best regards,
David

Software Engineer
Highgo Software Inc. (Canada)
www.highgo.ca

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-04-19 20:06:28 Re: Postgres perl module namespace
Previous Message Tom Lane 2022-04-19 19:16:05 Re: error handling in pqRowProcessor broken