| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minimal logical decoding on standbys |
| Date: | 2022-12-20 20:35:13 |
| Message-ID: | a43398e8-51c4-467f-8b56-c17d6ba03870@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 12/20/22 7:31 PM, Robert Haas wrote:
> On Tue, Dec 20, 2022 at 1:19 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>> I don't understand what the "may*" or "*Possible" really are
>> about. snapshotConflictHorizon is a conflict with a certain xid - there
>> commonly won't be anything to conflict with. If there's a conflict in
>> the logical-decoding-on-standby case, we won't be able to apply it only
>> sometimes or such.
>
> The way I was imagining it is that snapshotConflictHorizon tells us
> whether there is a conflict with this record and then, if there is,
> this new Boolean tells us whether it's relevant to logical decoding as
> well.
>
the "may*" or "*Possible" was, most probably, because I preferred to have the uncertainty of the conflict mentioned in the name.
But, somehow, I was forgetting about the relationship with snapshotConflictHorizon.
So, agree with both of you that mentioning about the uncertainty of the conflict is useless.
>> How about "affectsLogicalDecoding", "conflictsWithSlots" or
>> "isCatalogRel" or such?
>
> isCatalogRel seems fine to me.
For me too, please find attached v34 using it.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v34-0006-Fixing-Walsender-corner-case-with-logical-decodi.patch | text/plain | 7.5 KB |
| v34-0005-Doc-changes-describing-details-about-logical-dec.patch | text/plain | 2.1 KB |
| v34-0004-New-TAP-test-for-logical-decoding-on-standby.patch | text/plain | 20.4 KB |
| v34-0003-Allow-logical-decoding-on-standby.patch | text/plain | 11.5 KB |
| v34-0002-Handle-logical-slot-conflicts-on-standby.patch | text/plain | 27.7 KB |
| v34-0001-Add-info-in-WAL-records-in-preparation-for-logic.patch | text/plain | 31.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-12-20 20:39:26 | Re: Minimal logical decoding on standbys |
| Previous Message | Andrey Borodin | 2022-12-20 18:39:29 | Re: MultiXact\SLRU buffers configuration |