Re: Why does create_gather_merge_plan need make_sort?

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: James Coleman <jtc331(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why does create_gather_merge_plan need make_sort?
Date: 2020-11-29 21:10:03
Message-ID: a3fda974-fbfe-66b3-eeb8-5670a942098c@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/29/20 3:44 PM, James Coleman wrote:
> On Mon, Nov 23, 2020 at 8:19 AM James Coleman <jtc331(at)gmail(dot)com> wrote:
>>
>> ..
>>
>> So I'm +1 on turning it into an ERROR log instead, since it seems to
>> me that encountering this case would almost certainly represent a bug
>> in path generation.
>
> Here's a patch to do that.
>

Thanks. Isn't the comment incomplete? Should it mention just parallel
safety or also volatility?

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2020-11-29 21:20:39 Re: Fix generate_useful_gather_paths for parallel unsafe pathkeys
Previous Message Tomas Vondra 2020-11-29 21:02:22 Re: Additional improvements to extended statistics