From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Todd Cook <cookt(at)blackduck(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com> |
Subject: | Re: TEMP_CONFIG vs test_aio |
Date: | 2025-04-02 12:34:11 |
Message-ID: | a3f43549-1d1d-44a5-b7ab-33327b899ee1@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 2025-04-01 Tu 5:34 PM, Andres Freund wrote:
> Hi,
>
> On 2025-04-01 17:08:49 -0400, Andrew Dunstan wrote:
>> On 2025-04-01 Tu 4:17 PM, Andres Freund wrote:
>>> For one using PG_TEST_INITDB_EXTRA_OPTS would probably require changing the
>>> buildfarm code, because the buildfarm code filters out environment variables
>>> that aren't on an allowlist (I really dislike that).
>>
>> Uh, not quite. Anything in the config's build_env is not filtered out. That
>> change was made a year ago.
> Huh. Just recently I tried to configure PG_TEST_TIMEOUT_DEFAULT in build_env
> and did not take effect until I explicitly added it to the @safe_set.
>
Correction: the code changed was a year ago, bit it was in release 18,
which was in November. If it didn't work after that I want to know.
This is the commit:
https://github.com/PGBuildFarm/client-code/commit/e2dd43915b4aa97447a5e8118f733b444896db81
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2025-04-02 12:42:13 | pgsql: Add timingsafe_bcmp(), for constant-time memory comparison |
Previous Message | Andres Freund | 2025-04-02 12:31:02 | pgsql: tests: Fix incompatibility of test_aio with *_FORCE_RELEASE |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2025-04-02 12:35:59 | Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote |
Previous Message | Peter Eisentraut | 2025-04-02 12:32:31 | Re: NOT ENFORCED constraint feature |