| From: | Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Syntax for partitioning |
| Date: | 2009-11-20 05:44:58 |
| Message-ID: | a301bfd90911192144g41ce4a2do50cfefe75a47615f@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
>> > partinfo = (PartitionInfo *) malloc(ntups * sizeof(PartitionInfo));
>
> 1) Please stop casting the results of palloc and malloc. We are not
> writing C++ here.
>
I thought it was/is a good C programming practice to typecast (void *)
always to the returning structure type!!
Regards,
Nikhils
> 2) I would prefer that you apply sizeof on the variable, not on the
> type. That way, the expression is independent of any type changes of
> the variable, and can be reviewed without having to scroll around for
> the variable definition.
>
> So how about,
>
> partinfo = palloc(ntups * sizeof(*partinfo));
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-11-20 05:49:20 | Re: Union test case broken in make check? |
| Previous Message | Jan Wieck | 2009-11-20 05:30:54 | Re: Why do OLD and NEW have special internal names? |