Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Srinath Reddy <srinath2133(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?
Date: 2025-01-25 16:18:35
Message-ID: a2d53e8b-4fdd-4d4c-ad61-b4298ddaf9fc@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2025-01-25 Sa 8:12 AM, Srinath Reddy wrote:
> ./pg_dump postgres -Fp -f textdump
>
> ./pg_restore -Fp -d postgres textdump
> pg_restore: error: unrecognized archive format "p"; please specify
> "c", "d", or "t"
>
> ./pg_restore -d postgres textdump
> pg_restore: error: input file appears to be a text format dump. Please
> use psql.
>
> wouldn't it be nice if we get the error message as same as when we
> didn't gave format option and pg_restore finds the format
> using _discoverArchiveFormat there it suggests to try psql ,instead of
> saying "p/plain text" format is a invalid format,as we are doing
> currently in pg.
>
> thoughts?
>

Probably not exactly the same, because in one case you're explicitly
saying it's a text dump. But maybe something closer would work, like

   "text format not supported. Please use psql."

cheers

andrew

--

Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-01-25 16:25:01 Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?
Previous Message Pavel Stehule 2025-01-25 15:05:10 Re: XMLDocument (SQL/XML X030)