| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
| Cc: | craig(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: REPLICA IDENTITY FULL |
| Date: | 2017-06-23 13:00:01 |
| Message-ID: | a2902ad8-554a-4d59-a142-ae0cac521697@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/20/17 00:10, Andres Freund wrote:
> On 2017-06-20 11:52:10 +0900, Tatsuo Ishii wrote:
>> If my understanding is correct, it would not be easy to fix, no?
>>
>>> We might be able to refine that, but there is a general problem that
>>> without an index and an operator class, we are just doing our random
>>> best to match the values.
>
> I don't see the problem as being big. We should just look up the
> default btree opclass and use the relevant operator. That's a how a
> number of things already work.
Patch for that.
Any thoughts about keeping datumAsEqual() as a first check? I did some
light performance tests, but it was inconclusive.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-replication-with-replica-identity-full.patch | text/plain | 7.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-06-23 13:07:47 | Removing deprecation changing automatically type of opaque functions |
| Previous Message | Thomas Munro | 2017-06-23 11:48:28 | Re: Causal reads take II |