| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Handle infinite recursion in logical replication setup |
| Date: | 2023-08-16 13:50:09 |
| Message-ID: | a1a8b807-623d-b155-6f88-705afaf96df1@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.08.23 04:50, Peter Smith wrote:
> On Tue, Aug 8, 2023 at 6:52 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>> On Tue, Aug 8, 2023 at 1:50 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>>
>>> This patch added the following error message:
>>>
>>> errdetail_plural("Subscribed publication %s is subscribing to other
>>> publications.",
>>> "Subscribed publications %s are subscribing to other publications.",
>>> list_length(publist), pubnames->data),
>>>
>>> But in PostgreSQL, a publication cannot subscribe to a publication, so
>>> this is not giving accurate information. Apparently, what it is trying
>>> to say is that
>>>
>>> The subscription that you are creating subscribes to publications that
>>> contain tables that are written to by other subscriptions.
>>>
>>> Can we get to a more accurate wording like this?
>>>
>>
>> +1 for changing the message as per your suggestion.
>>
>
> PSA a patch to change this message text. The message now has wording
> similar to the suggestion.
committed, thanks
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-08-16 13:54:57 | dubious warning: FORMAT JSON has no effect for json and jsonb types |
| Previous Message | Shaun Thomas | 2023-08-16 13:26:55 | Re: Logging of matching pg_hba.conf entry during auth skips trust auth, potential security issue |