| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, craig(at)2ndquadrant(dot)com |
| Subject: | Re: REPLICA IDENTITY FULL |
| Date: | 2017-12-11 21:40:07 |
| Message-ID: | a1176974-3263-49bc-3b13-6144529f20ee@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/4/17 22:15, Noah Misch wrote:
> While reviewing this patch, I noticed a couple of nearby defects:
>
> - RelationFindReplTupleSeq() says "Note that this stops on the first matching
> tuple.", but that's not the case. It visits every row in the table, and it
> uses the last match. The claimed behavior sounds more attractive.
Yeah, that looks like a mistake.
> - RelationFindReplTupleSeq() has comment "/* Start an index scan. */", an
> inapplicable copy-paste from RelationFindReplTupleByIndex().
I have fixed that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-12-11 21:45:51 | Re: [HACKERS] static assertions in C++ |
| Previous Message | Tom Lane | 2017-12-11 21:39:08 | Re: Jsonb transform for pl/python |