| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix smgrtruncate code comment. |
| Date: | 2024-07-29 11:27:03 |
| Message-ID: | a07747e1-a020-44b8-8897-1c00179911d0@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29/07/2024 13:50, Kirill Reshke wrote:
> Today I was busy rebasing my Greenplum-related Extendable SMGR
> patches on Cloudberry, and I faced some conflicts.
> While resolving them I noticed code & comments inconsistency in smgr.c
> in smgrtruncate function, which tracks down to
> c5315f4f44843c20ada876fdb0d0828795dfbdf5. In this commit,
> smgr_fsm_nblocks & smgr_vm_nblocks fields were removed, however
> comments were not fixed accordingly.
>
> So i suggest to fix this, PFA
Applied, thanks!
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-07-29 11:42:16 | Re: Remove duplicate table scan in logical apply worker and code refactoring |
| Previous Message | Heikki Linnakangas | 2024-07-29 11:18:40 | Remove dead code generation tools in src/backend/utils/mb/ |