Re: fix deprecation mention for age() and mxid_age()

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: fix deprecation mention for age() and mxid_age()
Date: 2024-11-19 06:52:40
Message-ID: Zzw1uMeWNSYyDeqd@ip-10-97-1-34.eu-west-3.compute.internal
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, Nov 19, 2024 at 10:09:57AM +0900, Michael Paquier wrote:
> On Mon, Nov 18, 2024 at 08:11:57AM +0000, Bertrand Drouvot wrote:
> > Also it looks like that for PG 16, 7471230cc6, did put the functions description
> > in the "Control Data Functions". That looks unintentional too, so moving it to
> > "Transaction ID and Snapshot Information Functions" section instead.
> >
> > Please find attached the 3 patches.
>
> Even with the monitoring query argument left aside, I agree that there
> are more upsides to not list them as deprecated for now, based on the
> reason that xid is still a data type in some catalogs, like pg_class's
> relfrozenxid and relminmxid.

Yeah, and those are most probably the main inputs for age(). In addition,
datminmxid and relminmxid are also xid and most probably the main inputs for
mxid_age().

> In short, your suggestion makes sense to me.

Thanks for the feedback!

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message by Yang 2024-11-19 07:08:26 Re: memory leak in pgoutput
Previous Message Will Mortensen 2024-11-19 06:45:12 README.tuplock and SHARE lock