| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: per backend I/O statistics |
| Date: | 2024-11-22 01:36:29 |
| Message-ID: | Zz_gHQ2g8MUe8oJ1@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 21, 2024 at 05:23:42PM +0000, Bertrand Drouvot wrote:
> So, given that:
>
> - the end result would be the same
> - the code changes would be non negligible (unless we have a better idea than
> pgstat_get_entry_ref() returning a NULL value).
Hmm. created_entry only matters for pgstat_init_function_usage().
All the other callers of pgstat_prep_pending_entry() pass a NULL
value. This makes me wonder if there is an argument for reworking a
bit that. There's a fat comment about the reason why, still, that
would make the get interface for variable-numbered stats a lot
leaner.. Not sure what to think about that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-11-22 02:31:04 | Re: Add a write_to_file member to PgStat_KindInfo |
| Previous Message | Michael Paquier | 2024-11-22 01:15:26 | Re: Add a write_to_file member to PgStat_KindInfo |