| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add a write_to_file member to PgStat_KindInfo |
| Date: | 2024-11-21 08:49:31 |
| Message-ID: | Zz70G7GbQklQEdUD@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Nov 21, 2024 at 04:26:47PM +0900, Michael Paquier wrote:
> On Thu, Nov 21, 2024 at 06:32:03AM +0000, Bertrand Drouvot wrote:
> > That was in fact the main reason why I added this test. But well, just
> > adding the "write_to_file" in the injection test is enough to "show" that this
> > member does exist. So I'm fine with v3.
>
> Plus/minus some tweaks in the wordings (like a s/stat /stats /),
I think the singular was ok here, but v4 (just shared up-thread) uses your
proposal.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilia Evdokimov | 2024-11-21 09:17:22 | Re: Sample rate added to pg_stat_statements |
| Previous Message | Bertrand Drouvot | 2024-11-21 08:49:13 | Re: Add a write_to_file member to PgStat_KindInfo |