Re: pg_dump --no-comments confusion

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Erik Wienhold <ewie(at)ewie(dot)name>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump --no-comments confusion
Date: 2024-11-20 19:47:58
Message-ID: Zz487iu-8hFqaM2i@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 18, 2024 at 05:14:53PM -0500, Tom Lane wrote:
> Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> writes:
> > But it would be good to have this patch applied to all supported versions,
> > as soon as nothing was changed on that pg_dump option, no ?
>
> Even more to the point, should we change pg_dump's help output?
>
> ...
> --load-via-partition-root load partitions via the root table
> --no-comments do not dump comments
> --no-publications do not dump publications
> ...
>
> Also, the identical text appears in pg_dumpall's man page and help
> output, while pg_restore has a differently worded version:
>
> printf(_(" --no-comments do not restore comments\n"));
>
> pg_restore's man page seems OK though:
>
> Do not output commands to restore comments, even if the archive
> contains them.

Fixed in the attached applied patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"

Attachment Content-Type Size
master.diff text/x-diff 3.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2024-11-20 20:11:00 Re: ALTER TABLE uses a bistate but not for toast tables
Previous Message Peter Geoghegan 2024-11-20 19:40:05 Re: Adding skip scan (including MDAM style range skip scan) to nbtree