Re: pgsql: Make all ereport() calls within gram.y provide error locations.

Hi Tom,

On Thu, Oct 31, 2024 at 08:09:38PM +0000, Tom Lane wrote:
> Make all ereport() calls within gram.y provide error locations.
>
> This patch responds to a comment that I (tgl) made in the
> discussion leading up to 774171c4f, that really all errors
> occurring during raw parsing should provide error cursors.
> Syntax errors reported by Bison will have one, and most of
> the handwritten ereport's in gram.y already provide one,
> but there were a few stragglers.
>
> (It is not claimed that this handles every failure reachable
> during raw parsing --- out-of-memory is an obvious exception.
> But this makes a good start on cases that are likely to occur.)
>
> While we're at it, clean up the reported positions for errors
> associated with LIMIT/OFFSET clauses. Previously we were
> relying on applying exprLocation() to the contained expressions,
> but that leads to slightly odd cursor placement, e.g.

The tests of sepgsql need a refresh:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2024-10-31%2020%3A52%3A13

Thanks,
--
Michael