| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Raghuveer Devulapalli <raghuveer(dot)devulapalli(at)intel(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Popcount optimization using AVX512 |
| Date: | 2024-10-31 19:21:24 |
| Message-ID: | ZyPYtMqDnP_lZSO0@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 30, 2024 at 04:10:10PM -0500, Nathan Bossart wrote:
> On Wed, Oct 30, 2024 at 08:53:10PM +0000, Raghuveer Devulapalli wrote:
>> BTW, I just realized function attributes for xsave and avx512 don't work
>> on MSVC (see
>> https://developercommunity.visualstudio.com/t/support-function-target-attribute-and-mutiversioning/10130630)
>> Not sure if you care about it. Its an easy fix (see
>> https://gcc.godbolt.org/z/Pebdj3vMx)
>
> Oh, good catch. IIUC we only need to check for #ifndef _MSC_VER in the
> configure programs for meson. pg_attribute_target will be empty on MSVC,
> and I believe we only support meson builds there.
Here is an updated patch with this change.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-use-__attribute__-target-.-for-AVX-512-stuff.patch | text/plain | 25.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thom Brown | 2024-10-31 19:25:11 | Re: MultiXact\SLRU buffers configuration |
| Previous Message | Stepan Neretin | 2024-10-31 19:04:23 | Re: UUID v7 |