From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: define pg_structiszero(addr, s, r) |
Date: | 2024-10-31 00:59:35 |
Message-ID: | ZyLWd2jR8FO7j5UL@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Oct 31, 2024 at 07:55:45AM +1100, Peter Smith wrote:
> +/*
> + * Test if a memory region starting at p and of size len is full of zeroes.
> + */
> +static inline bool
> +pg_mem_is_all_zeros(const void *ptr, size_t len)
>
> The function comment should say 'ptr' instead of 'p', right?
Yes.
+static inline bool
+pg_mem_is_all_zeros(const void *ptr, size_t len)
While we're talking about wordsmithing things, I would not choose
"mem" for this routine, just stick to "memory". There is not much in
the code that does memory-specific things like what you are proposing
here. Still, this would be more consistent with the macros for memory
barriers at least. Hence, "pg_memory_is_all_zeros()" makes more
sense?
The location of memutils.h is sensible.
+ if (pg_mem_is_all_zeros(pagebytes , (BLCKSZ / sizeof(size_t))))
Extra space not required after pagebytes.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Andy Fan | 2024-10-31 01:11:14 | Re: Avoid detoast overhead when possible |
Previous Message | Hayato Kuroda (Fujitsu) | 2024-10-31 00:55:01 | RE: Conflict detection for update_deleted in logical replication |