| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Large expressions in indexes can't be stored (non-TOASTable) |
| Date: | 2024-10-30 20:54:32 |
| Message-ID: | ZyKdCEaUB2lB1rG8@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 18, 2024 at 08:08:55AM +0900, Michael Paquier wrote:
> 0002 and 0003 look sane enough to me as shaped. I'd need to spend a
> few more hours on 0001 if I were to do a second round on it, but you
> don't really need a second opinion, do you? :D
I'll manage. 0001 was a doozy to back-patch, and this obviously isn't a
terribly pressing issue, so I plan to wait until after the November minor
release to apply this. I'm having second thoughts on 0002, so I'll
probably leave that one uncommitted, but IMHO we definitely need 0003 to
prevent this issue from reoccurring.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Ensure-we-have-a-snapshot-when-updating-va.patch.master | text/plain | 6.8 KB |
| v5-0001-Ensure-we-have-a-snapshot-when-updating-vario.patch.v12 | text/plain | 2.4 KB |
| v5-0001-Ensure-we-have-a-snapshot-when-updating-vario.patch.v13 | text/plain | 2.4 KB |
| v5-0001-Ensure-we-have-a-snapshot-when-updating-vario.patch.v14 | text/plain | 4.8 KB |
| v5-0001-Ensure-we-have-a-snapshot-when-updating-vario.patch.v15 | text/plain | 6.6 KB |
| v5-0001-Ensure-we-have-a-snapshot-when-updating-vario.patch.v16 | text/plain | 7.2 KB |
| v5-0001-Ensure-we-have-a-snapshot-when-updating-vario.patch.v17 | text/plain | 7.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-10-30 20:55:45 | Re: define pg_structiszero(addr, s, r) |
| Previous Message | Raghuveer Devulapalli | 2024-10-30 20:53:10 | Re: Popcount optimization using AVX512 |