| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Andy Fan <zhihuifan1213(at)163(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Subject: | Re: -Wformat-signedness |
| Date: | 2024-10-29 06:51:11 |
| Message-ID: | ZyCF3yFVQl6xE19A@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 29, 2024 at 07:38:36AM +0100, Peter Eisentraut wrote:
> I think it could be useful to set up some better test coverage for various
> things overflowing signed integer maximums. For example, maybe you could
> hack initdb to advance the OID counter to INT32_MAX+1 or thereabouts and run
> the test suites from there. That would also catch things like inappropriate
> uses of atoi(), things beyond just the format strings.
Fun. One way to be fancy here would be to force a pg_resetwal
--next-oid in some of the test paths (Cluster.pm and/or pg_regress)
with an environment variable to force the command to trigger across
the board for all the clusters created in the tests. initdb cannot be
used here as the TAP tests reuse a cluster already initdb'd to save
time. No need to touch at pg_regress, either, as we could count on the
pg_regress runs in 002_pg_upgrade.pl and 027_stream_regress.pl.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2024-10-29 07:04:26 | Re: On disable_cost |
| Previous Message | Andy Fan | 2024-10-29 06:45:58 | Re: detoast datum into the given buffer as a optimization. |