Re: Refactor to use common function 'get_publications_str'.

On Wed, Oct 23, 2024 at 03:44:03PM +1100, Peter Smith wrote:
> During a code review, it was noticed that there are several places
> within logical replication where a comma-separated list of publication
> names is built explicitly. There is already a utility function (called
> 'get_publications_str') for doing this, but it was not being used in
> every place it could have been.

Agreed that this is a good idea, saving from some duplication in the
tablesync code where the same thing is done, with the quoting on top
of that.

- pfree(cmd.data);
+ pfree(pub_names->data);

The pfree for cmd.data should still be here, no? And you would need a
pfree(pub_names) as well, meaning that this could just use
destroyStringInfo().
--
Michael