Re: Use more CppAsString2() in pg_amcheck.c

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use more CppAsString2() in pg_amcheck.c
Date: 2024-10-18 17:22:26
Message-ID: ZxKZUprDJOkRmET4@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 18, 2024 at 06:50:50PM +0900, Michael Paquier wrote:
> - appendPQExpBufferStr(&sql, "\nWHERE c.relpersistence != 't'");
> + appendPQExpBufferStr(&sql, "\nWHERE c.relpersistence != "
> + CppAsString2(RELPERSISTENCE_TEMP) " ");

I think these whitespace changes may cause invalid statements to be
produced in some code paths. IMHO those should be reserved for a separate
patch, anyway.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Nathan Bossart 2024-10-18 16:31:54 Re: Proposal for Updating CRC32C with AVX-512 Algorithm.