Re: wrong comment in libpq.h

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: David Zhang <david(dot)zhang(at)highgo(dot)ca>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: wrong comment in libpq.h
Date: 2024-10-17 02:45:41
Message-ID: ZxB6VU3587pkp5Ss@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 10, 2024 at 11:14:51AM -0700, David Zhang wrote:
>
> > It looks like this wording "prototypes for functions in" is used many
> > times in src/include/, in many cases equally inaccurately, so I would
> > suggest creating a more comprehensive patch for this.
>
> I noticed this "prototypes for functions in" in many header files and
> briefly checked them. It kind of all make sense except the bufmgr.h has
> something like below.
>
> /* in buf_init.c */
> extern void InitBufferPool(void);
> extern Size BufferShmemSize(void);
>
> /* in localbuf.c */
> extern void AtProcExit_LocalBuffers(void);
>
> /* in freelist.c */
>
> which doesn't say "prototypes for functions xxx", but it still make sense
> for me.

I looked at this and decided the GUC section was illogical, so I just
moved the variables up into the be-secure.c section. Patch attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"

Attachment Content-Type Size
include.diff text/x-diff 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Lepikhov 2024-10-17 03:57:50 Re: Considering fractional paths in Append node
Previous Message Andrei Lepikhov 2024-10-17 02:09:29 Re: POC, WIP: OR-clause support for indexes