Re: Large expressions in indexes can't be stored (non-TOASTable)

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
Date: 2024-10-16 15:54:45
Message-ID: Zw_hxaDoC3TzQYjj@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 16, 2024 at 10:24:32AM +0900, Michael Paquier wrote:
> On Tue, Oct 15, 2024 at 08:20:17PM -0500, Nathan Bossart wrote:
>> I assume all of this will get compiled out in non-USE_ASSERT_CHECKING
>> builds as-is, but I see no problem with surrounding it with an #ifdef to be
>> sure.
>
> Yeah, I'm not sure that that would always be the case when optimized.
> Code generated can be dumb sometimes even if compilers got much
> smarter in the last 10 years or so (not compiler guy here).

Here is a new version of the patch set with this #ifdef added. I plan to
give each of the code paths adjusted by 0001 a closer look, but otherwise
I'm hoping to commit these soon.

--
nathan

Attachment Content-Type Size
v4-0001-Ensure-we-have-a-snapshot-when-updating-various-s.patch text/plain 5.5 KB
v4-0002-Introduce-RelationGetToastRelid-macro.patch text/plain 12.8 KB
v4-0003-Assert-that-we-have-a-valid-snapshot-if-we-might-.patch text/plain 2.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2024-10-16 16:04:50 Re: New "raw" COPY format
Previous Message Jacob Champion 2024-10-16 15:30:56 Re: Add support to TLS 1.3 cipher suites and curves lists