| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Christophe Pettus <xof(at)thebuild(dot)com>, vaibhave postgres <postgresvaibhave(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)lists(dot)postgresql(dot)org, vsekar(at)microsoft(dot)com |
| Subject: | Re: vacuumdb: permission denied for schema "pg_temp_7" |
| Date: | 2024-10-07 19:54:18 |
| Message-ID: | ZwQ8anV_Xn62frq-@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Oct 07, 2024 at 12:40:54PM -0700, Noah Misch wrote:
> On Mon, Oct 07, 2024 at 11:16:33AM -0500, Nathan Bossart wrote:
>> For consistency with the surrounding code, I think we should schema-qualify
>> the operator and add a newline after "WHERE relpersistence != 't'". If
>> folks agree, I can handle committing the attached patch.
>
> Not just code consistency. A code comment requires the schema qualification:
>
> * Since we execute the constructed query with the default search_path
> * (which could be unsafe), everything in this query MUST be fully
> * qualified.
D'oh. I'm listed as the author of the commit that added that comment and
should've remembered it. I'll just go apply the patch now, then.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-10-07 21:51:14 | Re: vacuumdb: permission denied for schema "pg_temp_7" |
| Previous Message | Noah Misch | 2024-10-07 19:40:54 | Re: vacuumdb: permission denied for schema "pg_temp_7" |