| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve node type forward reference |
| Date: | 2024-10-14 21:28:34 |
| Message-ID: | Zw2NAr_ABwpD2t-9@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 14, 2024 at 09:47:59AM +0200, Peter Eisentraut wrote:
> But we can do this better by using an incomplete struct, like
>
> struct Query *viewQuery ...;
>
> That way, everything has the correct type and fewer casts are required. This
> technique is already used elsewhere in node type definitions.
I noticed that the examples in parsenodes.h are for structs defined within
the same file. If the struct is defined in a separate file, I guess you
might need to include another header file wherever it is used, but that
doesn't seem too bad.
> The second patch just removes some more unnecessary casts around
> copyObject() that I found while working on this.
LGTM
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2024-10-14 22:25:17 | Re: BitmapHeapScan streaming read user and prelim refactoring |
| Previous Message | Bruce Momjian | 2024-10-14 21:15:18 | Re: Changing the default random_page_cost value |