Patch: Make pg_waldump.sgml less confusing

From: Christoph Berg <myon(at)debian(dot)org>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, David Christensen <david(dot)christensen(at)crunchydata(dot)com>
Subject: Patch: Make pg_waldump.sgml less confusing
Date: 2024-10-01 21:44:40
Message-ID: ZvxtSLiix9eceMRM@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The pg_waldump manpage says the --save-fullpage output format was

TIMELINE-LSN.RELTABLESPACE.DATOID.RELNODE.BLKNOFORK

when the filenames actually have the format

00000001-00000000-309A88C0.1663.5.64080.0_main

with an underscore in front of FORK.

While that is technically correct because it then explains that
FORK is something like "_main", I think this is just confusing and
moving the underscore into the file name format description is much
cleaner. (And inside the rest of the code, the fork names don't have
underscore prefixes either.)

Christoph

Attachment Content-Type Size
0001-pg_waldump.sgml-Put-underscore-in-front-of-FORK.patch text/x-diff 1.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-10-01 22:51:06 Re: Patch: Make pg_waldump.sgml less confusing
Previous Message Tom Lane 2024-10-01 20:17:19 Re: Fixing backslash dot for COPY FROM...CSV