| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tender Wang <tndrwang(at)gmail(dot)com> |
| Cc: | exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18630: Incorrect memory access inside ReindexIsProcessingIndex() on VACUUM |
| Date: | 2024-09-27 00:45:12 |
| Message-ID: | ZvYAGAdUEArQsOdA@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Sep 26, 2024 at 03:24:25PM +0800, Tender Wang wrote:
> Agree. The attached patch LGTM.
I have fixed this issue and backpatched it all the way down for now.
One thing that we still lack is a set of reliable tests. This can be
achieved with injection points, and that's much broader than only this
thread. I'd like to get the coverage with two types of tests,
roughly:
- Isolation, with waits across the steps of REINDEX CONCURRENTLY, and
some concurrent operation. This thread used one.
- SQL tests, where we could force errors in some code paths to get an
incorrect state. Putting ourselves in a corner where there is an
invalid toast index is just one state. CIC with a UNIQUE index gives
this possibility, but this just works for a "new" index, for early
stages of REINDEX CONCURRENTLY.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-09-27 00:48:56 | Re: vacuumdb: permission denied for schema "pg_temp_7" |
| Previous Message | Tom Lane | 2024-09-26 22:41:29 | Re: BUG #18634: Wrong varnullingrels with merge ... when not matched by source |