| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add contrib/pg_logicalsnapinspect |
| Date: | 2024-09-25 17:31:14 |
| Message-ID: | ZvRI4n+U466Mq6Q2@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed, Sep 25, 2024 at 11:23:17AM +0530, shveta malik wrote:
> + OUT catchange_xip xid[]
>
> One question, what is xid datatype, is it too int8? Sorry, could not
> find the correct doc.
I think that we can get the answer from pg_type:
postgres=# select typname,typlen from pg_type where typname = 'xid';
typname | typlen
---------+--------
xid | 4
(1 row)
> Since we are getting uint32 in Int64, this also needs to be accordingly.
I think the way it is currently done is fine: we're dealing with TransactionId
(and not with FullTransactionId). So, the Int64GetDatum() output would still
stay in the "xid" range. Keeping xid in the .sql makes it clear that we are
dealing with transaction ID.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Westermann (DWE) | 2024-09-25 17:35:48 | Re: src/backend/optimizer/util/plancat.c -> Is this correct English |
| Previous Message | Bertrand Drouvot | 2024-09-25 17:29:09 | Re: Add contrib/pg_logicalsnapinspect |