From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Normalize queries starting with SET for pg_stat_statements |
Date: | 2024-09-25 03:10:02 |
Message-ID: | ZvN_Cr4pNNNc5j3H@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Sep 24, 2024 at 04:57:28PM +0900, Michael Paquier wrote:
> 0001 is straight-forward and that was I think a mistake to not include
> that from the start when I've expanded these tests in the v16 cycle
> (well, time..). 0002 also is quite conservative at the end, and this
> design can be used to tune easily the jumbling patterns from gram.y
> depending on the feedback we'd get.
Applied 0001 for now to expand the tests, with one tweak: the removal
of SET NAMES. It was proving tricky to use something else than UTF-8,
the CI complaining on Windows. True that this could use like unaccent
and an alternate output in a different file, but I'm not inclined to
take the cost just for this specific query pattern.
The remaining 0002 is attached for now. I am planning to wrap that
next week after a second lookup, except if there are any comments, of
course.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
v3-0002-Normalize-queries-starting-with-SET.patch | text/x-diff | 12.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2024-09-25 03:20:14 | Re: Eager aggregation, take 3 |
Previous Message | Noah Misch | 2024-09-25 03:03:45 | Re: Primary and standby setting cross-checks |