Re: Separate HEAP WAL replay logic into its own file

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Li, Yong" <yoli(at)ebay(dot)com>
Cc: Sutou Kouhei <kou(at)clear-code(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, "Debnath, Shawn" <sdn(at)ebay(dot)com>, "Shyrabokau, Anton" <antons(at)ebay(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Separate HEAP WAL replay logic into its own file
Date: 2024-09-11 07:41:49
Message-ID: ZuFJvZQdEy1G_s7n@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 30, 2024 at 06:48:26AM +0000, Li, Yong wrote:
> Thank you Kou for your review. I will move the CF to the next
> phase and see what happens.

Quite a fan of what you are proposing here, knowing that heapam.c is
still 8.8k lines of code even after moving the 1.3k lines dedicated to
WAL records.

+#include "access/heapam_xlog.h"

This is included in heapam.h, but missing from the patch. I guess
that you fat-fingered a `git add`.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Harris 2024-09-11 07:47:09 Re: ANALYZE ONLY
Previous Message Peter Eisentraut 2024-09-11 07:37:34 Re: [PoC] Federated Authn/z with OAUTHBEARER