| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typos in the code and README |
| Date: | 2024-09-04 01:25:17 |
| Message-ID: | Zte2_cC1x7IW5_Ez@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 03, 2024 at 12:00:13PM +0200, Daniel Gustafsson wrote:
> I see your v17 typo fixes, and raise you a few more. Commit 31a98934d169 from
> just now contains 2 (out of 3) sets of typos introduced in v17 so they should
> follow along when you push the ones mentioned here.
Is that really mandatory? I tend to worry about back branches only
when this stuff is user-visible, like in the docs or error messages.
This opinion varies for each individual, of course. That's just my
lazy opinion.
CommitTSSLRU -> CommitTsSLRU is user-visible, showing up in
pg_stat_activity. Fixed this one with 08b9b9e043bb, as the tag for
17rc1 has been pushed.
Picking f747bc18f7f2 and 75c5231a00f3 on REL_17_STABLE leads to the
attached, I think, without the conflicts.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-typos-and-grammar-in-code-comments-and-docs.patch | text/x-diff | 8.1 KB |
| 0002-Fix-typos-in-code-comments-and-test-data.patch | text/x-diff | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-09-04 01:41:49 | Re: optimizing pg_upgrade's once-in-each-database steps |
| Previous Message | Richard Guo | 2024-09-04 01:16:39 | Re: Wrong results with grouping sets |