Re: Add callbacks for fixed-numbered stats flush in pgstats

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: bertranddrouvot(dot)pg(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add callbacks for fixed-numbered stats flush in pgstats
Date: 2024-09-09 02:17:12
Message-ID: Zt5aqIhIvrCeJmmW@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 04, 2024 at 06:37:01PM +0900, Kyotaro Horiguchi wrote:
> I doubt that overprotection is always better, but in this case, it's
> not overprotection at all. The flush callbacks are called
> unconditionally once we decide to flush anything. Sorry for the noise.

Yes, it's intended to be a fastpath, with checks happening if we have
no data pending for any variable-numbered stats.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2024-09-09 02:20:27 Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Previous Message Peter Smith 2024-09-09 01:54:57 Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description