Re: Sequence Access Methods, round two

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Sequence Access Methods, round two
Date: 2024-08-26 04:45:12
Message-ID: ZswIWJ2UAlymgFjq@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 20, 2024 at 03:12:32PM +0900, Michael Paquier wrote:
> While on it, I have noticed a couple of conflicts while rebasing, so
> attached is a refreshed patch set.

Please find attached a new patch set for the next commit fest. The
patch has required a bit of work to be able to work on HEAD,
particularly around the fact that pg_sequence_read_tuple() is able to
do the same work as the modifications done for pg_sequence_last_value()
in the previous patch sets. I have modified the patch set to depend
on that, and adapted pg_dump/restore to it. The dump/restore part has
also required some tweaks to make sure that the AM is dumped depending
on if --schema-only and if we care about the values.

Finally, I have been rather annoyed by the addition of log_cnt in the
new function pg_sequence_read_tuple(). This patch set could also
implement a new system function, but it looks like a waste as we don't
care about log_cnt in pg_dump and pg_upgrade on HEAD, so I'm proposing
to remove it on a different thread:
https://www.postgresql.org/message-id/Zsvka3r-y2ZoXAdH%40paquier.xyz
--
Michael

Attachment Content-Type Size
v7-0001-Remove-log_cnt-from-pg_sequence_read_tuple.patch text/x-diff 3.6 KB
v7-0002-Remove-FormData_pg_sequence_data-from-init_params.patch text/x-diff 9.2 KB
v7-0003-Integrate-addition-of-attributes-for-sequences-wi.patch text/x-diff 11.1 KB
v7-0004-Refactor-code-for-in-core-local-sequences.patch text/x-diff 54.5 KB
v7-0005-Sequence-access-methods-backend-support.patch text/x-diff 61.3 KB
v7-0006-Sequence-access-methods-dump-restore-support.patch text/x-diff 21.7 KB
v7-0007-Sequence-access-methods-core-documentation.patch text/x-diff 9.5 KB
v7-0008-snowflake-Add-sequence-AM-based-on-it.patch text/x-diff 28.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nisha Moond 2024-08-26 04:53:00 Re: Conflict Detection and Resolution
Previous Message Tatsuo Ishii 2024-08-26 04:39:47 Re: Row pattern recognition