Re: Improving the notation for ecpg.addons rules

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improving the notation for ecpg.addons rules
Date: 2024-08-23 00:22:22
Message-ID: ZsfWPhlUgKhMCHe2@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 20, 2024 at 02:33:23PM -0400, Tom Lane wrote:
> I wrote:
>> Yeah, I was wondering about that. I wouldn't do it exactly like
>> that, but with a check that the entry gets matched somewhere.
>
> Here's a patch for that (again based on the other patch series).
> This did not turn up anything interesting, but it's probably
> worth keeping.

Okay, I see where you're going with this one. It does not seem like
this is going to cost much in long-term maintenance while catching
unfortunate issues, so +1 from me.

The patch does not apply on HEAD due to the dependency with the other
things you are proposing, and I would have hardcoded failures to check
that the reports are correct, but that looks neat on read.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-08-23 00:29:13 Re: MultiXact\SLRU buffers configuration
Previous Message Michael Paquier 2024-08-23 00:18:09 Re: Injection Points remaining stats