| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bind |
| Date: | 2024-08-22 07:33:54 |
| Message-ID: | Zsbp4sPKF_NlGsH4@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 21, 2024 at 09:29:04AM +0200, Anthonin Bonnefoy wrote:
> Here's the patch with \bindx renamed to \bind_named.
Looks OK to me. I have spent more time double-checking the whole, and
it looks like we're there, so applied. Now let's play with it in more
regression tests. Note that the refactoring patch has been merged
with the original one in a single commit.
> I've also made a small change to Michael's refactoring in 0002 by
> initialising success to false in ExecQueryAndProcessResults. There was
> a compiler warning about success possibly used uninitialized[1].
>
> [1] https://cirrus-ci.com/task/6207675187331072
Ah, thanks! I've missed this one. I see where my mistake was.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2024-08-22 07:34:05 | Redundant Result node |
| Previous Message | Noah Misch | 2024-08-22 07:32:00 | Re: race condition in pg_class |