Re: query ID goes missing with extended query protocol

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>
Subject: Re: query ID goes missing with extended query protocol
Date: 2024-08-28 22:48:07
Message-ID: Zs-pJ9dihDE1Nwlw@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 28, 2024 at 04:27:38PM -0400, Robert Haas wrote:
> - Add a call to
> pgstat_report_query_id(queryDesc->plannedstmt->queryId, false) to the
> top of ExecutorRun() with an appropriate comment.
> - Fix the incorrect comment mentioned above.
> - Back-patch to all releases containing 4f0b0966c86 i.e. v14+.

This is being discussed already on a different thread:
- Thread: https://www.postgresql.org/message-id/CA+427g8DiW3aZ6pOpVgkPbqK97ouBdf18VLiHFesea2jUk3XoQ@mail.gmail.com
- CF entry: https://commitfest.postgresql.org/49/4963/

There is a patch proposed there, that attempts to deal with the two
cases of a portal where ExecutorRun() is called once while holding a
tuplestore and where ExecutorRun() is called multiple times. A few
approaches have been discussed for the tests, where the new psql
metacommands added in d55322b0da60 should become handy. That's on my
TODO spreadsheet of things to look at, but I did not come back to it
yet.

A backpatch would be adapted for that, yep. I'd like to see tests on
HEAD at least.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-08-28 23:00:52 Re: Removing log_cnt from pg_sequence_read_tuple()
Previous Message Mark Murawski 2024-08-28 22:39:10 Re: pl/pgperl Patch for adding $_FN detail just like triggers have for $_TD