| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | remove volatile qualifiers from pg_stat_statements |
| Date: | 2024-07-30 18:24:54 |
| Message-ID: | Zqkv9iK7MkNS0KaN@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While looking into converting pgssEntry->mutex to an LWLock (per a
suggestion elsewhere [0]), I noticed that pg_stat_statements uses
"volatile" quite liberally. IIUC we can remove these as of commit 0709b7e
(like commits 8f6bb85, df4077c, and 6ba4ecb did in other areas). All of
the uses in pg_stat_statements except those added by commit 9fbc3f3 predate
that commit (0709b7e), and I assume commit 9fbc3f3 was just following the
examples in surrounding code.
Am I missing something? Or can we remove these qualifiers now?
[0] https://postgr.es/m/20200911223254.isq7veutwxat4n2w%40alap3.anarazel.de
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-remove-volatile-qualifiers-from-pg_stat_statement.patch | text/plain | 13.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-07-30 19:13:12 | Re: tiny step toward threading: reduce dependence on setlocale() |
| Previous Message | Melih Mutlu | 2024-07-30 17:19:30 | Do we still need parent column in pg_backend_memory_context? |