| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | px shi <spxlyy123(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: CREATE MATERIALIZED VIEW |
| Date: | 2024-07-25 14:54:01 |
| Message-ID: | ZqJnCV1pH99TUF7v@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 25, 2024 at 03:49:02PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> However, since it looks like the feature was never actually supported in a
>> release, and the revert has been in place for over a decade, I think it'd
>> be reasonable to remove the tab completion now. It looks like the folks on
>> the 2021 thread felt similarly.
>
> Keeping it in the grammar makes sense for the more specific error
> message, but I don't think the tab completion should be suggesting bogus
> things, regardless of whether it's the grammar or the parse analysis
> that rejects it.
Would you mind creating a commitfest entry for this one? I'll plan on
committing this early next week unless any objections materialize.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2024-07-25 15:10:37 | Re: CREATE MATERIALIZED VIEW |
| Previous Message | Dagfinn Ilmari Mannsåker | 2024-07-25 14:49:02 | Re: CREATE MATERIALIZED VIEW |