| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | px shi <spxlyy123(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: CREATE MATERIALIZED VIEW |
| Date: | 2024-07-25 14:38:30 |
| Message-ID: | ZqJjZscmd5TrTR36@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 25, 2024 at 03:09:09PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Scratch that, I misread the diff. The tab completion has been there
> since matviews were added in commit 3bf3ab8c5636, but the restriction on
> unlogged matviews was added later in commit 3223b25ff73, which failed to
> update the tab completion code to match.
As noted a few years ago [0], the commit message for 3223b25ff73 indicates
this was intentional:
I left the grammar and tab-completion support for CREATE UNLOGGED
MATERIALIZED VIEW in place, since it's harmless and allows delivering a
more specific error message about the unsupported feature.
However, since it looks like the feature was never actually supported in a
release, and the revert has been in place for over a decade, I think it'd
be reasonable to remove the tab completion now. It looks like the folks on
the 2021 thread felt similarly.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2024-07-25 14:49:02 | Re: CREATE MATERIALIZED VIEW |
| Previous Message | Amit Langote | 2024-07-25 14:16:45 | Re: pgsql: Add more SQL/JSON constructor functions |