| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx |
| Date: | 2024-07-19 02:23:08 |
| Message-ID: | ZpnODDZT-aosIUAE@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 19, 2024 at 12:17:44AM +0200, Tomas Vondra wrote:
> shall we do something about this patch? It seems to be in a pretty good
> shape (pretty much RFC, based on quick review), the cfbot is still
> happy, and there seems to be agreement this is a nice feature.
>
> Michael, I see you've reviewed the patch in January. Do you agree / plan
> to get it committed, or should I take a look?
This feel off my radar a bit, thanks for the reminder :)
I have a local branch dating back from January where this patch is
sitting, with something like 50% of the code reviewed. I'd still need
to look at the test coverage, but I did like the proposed patch a lot
based on my notes.
I may be able to come back to that if not next week, then the week
after that. If you want to handle it yourself before that, that's
fine by me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-07-19 02:35:18 | Re: Internal error codes triggered by tests |
| Previous Message | torikoshia | 2024-07-19 01:37:47 | Re: Add on_error and log_verbosity options to file_fdw |