Re: Flush pgstats file during checkpoints

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Flush pgstats file during checkpoints
Date: 2024-07-16 01:37:39
Message-ID: ZpXO4xo_RnaT_6I3@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 12, 2024 at 01:01:19PM +0000, Bertrand Drouvot wrote:
> Instead of removing the stat file, should we keep it around until the first call
> to pgstat_write_statsfile()?

Oops. You are right, I have somewhat missed the unlink() once we are
done reading the stats file with a correct redo location.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2024-07-16 01:52:26 Re: Confine vacuum skip logic to lazy_scan_skip
Previous Message Michael Paquier 2024-07-16 01:32:01 Re: Internal error codes triggered by tests