Re: Remove dependence on integer wrapping

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Joseph Koshakow <koshy44(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Remove dependence on integer wrapping
Date: 2024-07-22 21:36:33
Message-ID: Zp7Q4erYWVjtWzQr@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 22, 2024 at 05:20:15PM -0400, Joseph Koshakow wrote:
> On Mon, Jul 22, 2024 at 11:17 AM Nathan Bossart <nathandbossart(at)gmail(dot)com>
> wrote:
>> Am I understanding correctly that the main
>> behavioral difference between these two approaches is that users will see
>> different error messages?
>
> Yes, you are understanding correctly. The approach written above will
> have the error message "array upper bound is too large", while the
> approach attached in patch
> v13-0002-Remove-overflow-from-array_set_slice.patch will have the error
> message "array lower bound is too large".

Okay. I'll plan on committing v13-0002 in the next couple of days, then.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Isaac Morland 2024-07-22 21:40:55 Re: [PATCH] GROUP BY ALL
Previous Message David G. Johnston 2024-07-22 21:33:57 Re: [PATCH] GROUP BY ALL