From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: allow changing autovacuum_max_workers without restarting |
Date: | 2024-07-08 19:29:16 |
Message-ID: | Zow-DBaDY2IzAzA2@nathan |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Here is a rebased patch.
One thing that still bugs me is that there is no feedback sent to the user
when autovacuum_max_workers is set higher than autovacuum_worker_slots. I
think we should at least emit a WARNING, perhaps from the autovacuum
launcher, i.e., once when the launcher starts and then again as needed via
HandleAutoVacLauncherInterrupts(). Or we could fail to start in
PostmasterMain() and then ignore later misconfigurations via a GUC check
hook. I'm not too thrilled about adding more GUC check hooks that depend
on the value of other GUCs, but I do like the idea of failing instead of
silently proceeding with a different value than the user configured. Any
thoughts?
--
nathan
Attachment | Content-Type | Size |
---|---|---|
v7-0001-allow-changing-autovacuum_max_workers-without-res.patch | text/plain | 17.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-07-08 19:30:20 | Re: Improve the connection failure error messages |
Previous Message | John H | 2024-07-08 19:12:13 | Re: Allow logical failover slots to wait on synchronous replication |