Re: Allow non-superuser to cancel superuser tasks.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, "Leung, Anthony" <antholeu(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Allow non-superuser to cancel superuser tasks.
Date: 2024-07-10 05:24:29
Message-ID: Zo4bDSyQTtqmotJV@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 10, 2024 at 10:03:04AM +0500, Kirill Reshke wrote:
> The problem is the error message has been changed.
>
> # DETAIL: Only roles with privileges of the
> "pg_signal_autovacuum_worker" role may terminate autovacuum workers.'
> # doesn't match '(?^:ERROR: permission denied to terminate
> process\nDETAIL: Only roles with privileges of the
> "pg_signal_autovacuum_worker" role may terminate autovacuum worker
> processes.)'
> # Looks like you failed 1 test of 2.
>
> I changed the test to match the error message.

The script has two tests, and the CI is failing for the second test
where we expect the signal to be processed:
[12:48:23.370] # Failed test 'autovacuum worker signaled with
pg_signal_autovacuum_worker granted'
[12:48:23.370] # at t/006_signal_autovacuum.pl line 90.

It is true that the first test where we expect the signal to not go
through also failed as the DETAIL string has been changed, which is
what you've fixed :)
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2024-07-10 05:31:47 Re: array_in sub function ReadArrayDimensions error message
Previous Message Michael Paquier 2024-07-10 05:14:55 Re: Allow non-superuser to cancel superuser tasks.