| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Pluggable cumulative statistics |
| Date: | 2024-07-11 13:29:08 |
| Message-ID: | Zo/eJIHUcqKxeSgv@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, Jul 05, 2024 at 09:35:19AM +0900, Michael Paquier wrote:
> On Thu, Jul 04, 2024 at 11:30:17AM +0000, Bertrand Drouvot wrote:
> >
> > /*
> > * Reads in existing statistics file into the shared stats hash.
> >
> > This comment above pgstat_read_statsfile() is not correct, fixed stats
> > are not going to the hash (was there before your patch though).
>
> Good catch. Let's adjust that separately.
Please find attached a patch to do so (attached as .txt to not perturb the
cfbot).
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-comment-on-top-of-pgstat_read_statsfile.txt | text/plain | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2024-07-11 13:34:04 | Re: speed up a logical replica setup |
| Previous Message | Noah Misch | 2024-07-11 12:52:07 | Re: MAINTAIN privilege -- what do we need to un-revert it? |